Skip to content

Improved URL handling#157

Merged
seiyria merged 2 commits intoLederCards:masterfrom
Lucretiel:better-url-handling
Dec 29, 2025
Merged

Improved URL handling#157
seiyria merged 2 commits intoLederCards:masterfrom
Lucretiel:better-url-handling

Conversation

@Lucretiel
Copy link
Contributor

Description

This PR makes two changes, both oriented around trying to have better URLs when sharing links:

  • The URL is no longer pre-emptively polluted with ?q=&d=images&s=name&b=asc&p=0. Instead, it only updates the query when the parameters change.
  • The URL copied by the share button on the Card page now omits the query, creating a much more pleasant URL like https://cards.ledergames.com/card/ARCS-F109

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have run tests (npm run test & npm run e2e) that prove my fix is effective or that my feature works

@seiyria seiyria merged commit 5c52924 into LederCards:master Dec 29, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants