tls_gnutls: Fix gnutls_transport_set_errno calls on Windows#692
Merged
bk138 merged 1 commit intoLibVNC:masterfrom Mar 10, 2026
Merged
tls_gnutls: Fix gnutls_transport_set_errno calls on Windows#692bk138 merged 1 commit intoLibVNC:masterfrom
bk138 merged 1 commit intoLibVNC:masterfrom
Conversation
gnutls_transport_set_errno takes a plain "gnutls_session_t", not
a "gnutls_session_t *".
This fixes build errors if building with a recent version of Clang
targeting Windows:
libvncserver/src/libvncclient/tls_gnutls.c:161:32: error: incompatible pointer types passing 'gnutls_session_t *' (aka 'struct gnutls_session_int **') to parameter of type 'gnutls_session_t' (aka 'struct gnutls_session_int *'); dereference with * [-Wincompatible-pointer-types]
161 | gnutls_transport_set_errno(session, EAGAIN);
| ^~~~~~~
| *
x86_64-w64-mingw32/include/gnutls/gnutls.h:2429:50: note: passing argument to parameter 'session' here
2429 | void gnutls_transport_set_errno(gnutls_session_t session, int err);
| ^
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gnutls_transport_set_errno takes a plain "gnutls_session_t", not a "gnutls_session_t *".
This fixes build errors if building with a recent version of Clang targeting Windows: