[BOOKINGSG-9274][GZ] v2 cleanup#1219
Open
ghazwan-gt wants to merge 4 commits into
Open
Conversation
ghazwan-gt
requested review from
iant-gds,
qroll,
ryan-nguyen-t,
zhaoyanxzy and
ziggyzet
qroll
requested changes
May 26, 2026
Contributor
qroll
left a comment
qroll
left a comment
There was a problem hiding this comment.
some other references to clean up:
rollup.config.js
v2_specdir is not longer present
preview-head.html
- V2 css reset https://assets.life.gov.sg/react-design-system/v2/css/main.css is no longer required
preview.ts
- can remove the custom story sort order for
"V2"section along with the next entry for the design token pages
| export interface PopoverProps { | ||
| import type { RefObject } from "react"; | ||
|
|
||
| export interface PopoverV2Props extends PopoverRenderProps { |
Contributor
There was a problem hiding this comment.
since we're changing the import paths, we might as well rename the typings to drop V2
the storybook docs should also reflect this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of changes
Description of changes
BOOKINGSG-9274
popover_v2is renamed topopover. The original one is deletedpopoverpopoverChecklist
Verification