[BOOKINGSG-9332][RYN] migrate file download component#1220
Open
ryan-nguyen-t wants to merge 5 commits into
Open
[BOOKINGSG-9332][RYN] migrate file download component#1220ryan-nguyen-t wants to merge 5 commits into
ryan-nguyen-t wants to merge 5 commits into
Conversation
added 5 commits
May 26, 2026 13:57
…lations to class names within the 'styled' tags
…' tags to Linaria 'css' tags
qroll
requested changes
May 28, 2026
Contributor
There was a problem hiding this comment.
include these cases:
- no title and description
- long file names (check line clamp behaviour)
qroll
requested changes
May 28, 2026
Contributor
qroll
left a comment
qroll
left a comment
There was a problem hiding this comment.
pending screenshots to be regenerated
Contributor
There was a problem hiding this comment.
the spacing does not look correct. why is there a gap on the left side of the list?
Contributor
There was a problem hiding this comment.
pending screenshots to be regenerated with the correct fonts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
classNameis chained correctly withclsx- [ ] Updated Storybook documentation- [ ] Added/updated unit tests