Skip to content

[BOOKINGSG-9340][IT] Migrate notification banner component#1221

Merged
qroll merged 12 commits into
pre-release/v4from
BOOKINGSG-9340
May 29, 2026
Merged

[BOOKINGSG-9340][IT] Migrate notification banner component#1221
qroll merged 12 commits into
pre-release/v4from
BOOKINGSG-9340

Conversation

@iant-gds
Copy link
Copy Markdown

Checklist

  • Migrated the component styles
    • className is chained correctly with clsx
    • User style prop is set as CSS variable
  • Changes follow the project guidelines in CONVENTIONS_V4.md
    - [ ] Updated Storybook documentation
  • Added/updated unit tests
  • Added visual tests
    - [ ] Listed breaking changes

@iant-gds iant-gds self-assigned this May 26, 2026
@iant-gds iant-gds marked this pull request as draft May 26, 2026 10:13
@iant-gds iant-gds marked this pull request as ready for review May 28, 2026 03:31
@qroll qroll added the type: chore For technical improvements or refactoring. label May 28, 2026
Comment thread src/notification-banner/notification-banner.tsx
Comment thread e2e/tests/components/notification-banner/notification-banner.e2e.spec.ts Outdated
Comment thread src/notification-banner/notification-banner.styles.ts Outdated
Comment thread src/notification-banner/notification-banner.styles.ts Outdated
Comment thread src/notification-banner/notification-banner.styles.ts
@qroll qroll added this to the v4.0.0-alpha.3 milestone May 29, 2026
@qroll qroll merged commit 5609138 into pre-release/v4 May 29, 2026
2 checks passed
@qroll qroll deleted the BOOKINGSG-9340 branch May 29, 2026 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: chore For technical improvements or refactoring.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants