Skip to content

[BOOKINGSG-9357] Fix loading animation for icon-only Button#1224

Open
qroll wants to merge 4 commits into
pre-release/v4from
BOOKINGSG-9357
Open

[BOOKINGSG-9357] Fix loading animation for icon-only Button#1224
qroll wants to merge 4 commits into
pre-release/v4from
BOOKINGSG-9357

Conversation

@qroll
Copy link
Copy Markdown
Contributor

@qroll qroll commented May 28, 2026

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing apis or functionality to change)

Description of changes

  • Ensure that the spinner can take up its required width by setting a flex-shrink: 0
  • Merged the documentation for the Button variants and reworked the examples to focus on the icon/label and style variants

Checklist

  • Changes follow the project guidelines in CONTRIBUTING.md and CONVENTIONS.md
  • Looks good on mobile and tablet (the story canvas gets cut off horizontally on mobile - it's happening across multiple components, to revisit another time)
  • Updated documentation
  • Added/updated tests

Screenshots

Before:

Screen.Recording.2026-05-28.at.11.23.33.AM.mov

After:

Screen.Recording.2026-05-28.at.12.35.16.PM.mov

@qroll qroll added this to the v4.0.0-alpha.3 milestone May 28, 2026
@qroll qroll added the type: bug Something isn't working label May 28, 2026
@qroll qroll force-pushed the BOOKINGSG-9357 branch from f5d39f5 to bf75b98 Compare May 28, 2026 08:07
@qroll qroll marked this pull request as ready for review May 28, 2026 08:32
@qroll qroll force-pushed the BOOKINGSG-9357 branch from bf75b98 to 7e67ac8 Compare May 28, 2026 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant