1주차 과제입니다 #21
Open
1주차 과제입니다 #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iubns
reviewed
Apr 16, 2025
Member
iubns
left a comment
iubns
left a comment
There was a problem hiding this comment.
상대방의 이름이 나올 수 있도록 해주세요!.
나머진 좋은거 같아요!
iubns
reviewed
Jun 2, 2025
Comment on lines
+11
to
+18
| {selectedFriend ? ( | ||
| <Chat | ||
| selectedFriend={selectedFriend} | ||
| onBack={() => setSelectedFriend(null)} | ||
| /> | ||
| ) : ( | ||
| <FriendList onSelectChat={setSelectedFriend} /> | ||
| )} |
Comment on lines
+1
to
+3
| import React, { useState, useRef, useEffect } from "react"; | ||
| import "./App.css"; | ||
|
|
Member
There was a problem hiding this comment.
해당 프로젝트의 package.json 파일은 어디 갔을까요?
Comment on lines
+9
to
+13
| .App { | ||
| display: flex; | ||
| flex-direction: column; | ||
| height: 100vh; | ||
| } |
Member
There was a problem hiding this comment.
css의 class name 중복을 방지하기 위해
css module을 사용해주세요.
Comment on lines
+15
to
+29
| <Routes> | ||
| <Route path="/" element={<Navigate to="/login" />} /> | ||
| <Route path="/login" element={<Login />} /> | ||
| <Route path="/register" element={<Register />} /> | ||
|
|
||
| {/* 채팅 화면 */} | ||
| <Route path="/chat" element={ | ||
| <FriendList onSelectChat={(friend) => setSelectedFriend(friend)} /> | ||
| } /> | ||
|
|
||
| {/* 친구 선택 후 이동할 채팅 화면 */} | ||
| <Route path="/chat/:friendName" element={ | ||
| <Chat selectedFriend={selectedFriend} onBack={() => setSelectedFriend(null)} /> | ||
| } /> | ||
| </Routes> |
Member
There was a problem hiding this comment.
router 라이브러리를 따로 사용한거 같네요.
next로 프로젝트를 세팅하면 필요 없습니다.
| const navigate = useNavigate(); | ||
|
|
||
| const handleLogin = () => { | ||
| console.log("로그인 시도:", id, pw); |
Comment on lines
+15
to
+16
| console.log("회원가입 시도:", id, pw); | ||
| navigate("/login"); |
Member
|
이전 과제가 많이 밀려서 한거번에 들어 왔네요. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.