Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
recommendsite기능을 헥사고날 아키텍처로 분리해 관심사를 명확히 하고 향후 어댑터/포트 교체를 쉽게 하려는 목적입니다.Description
adapter/in/web로 이동해 inbound adapter 경로로 정리하고RecommendSiteController를 새 위치에서 동작하도록 변경했습니다.RecommendSiteUseCase)과 애플리케이션 서비스(RecommendSiteService)를 추가해 비즈니스 로직을 application 계층으로 분리했습니다.domain/port/out/RecommendSiteQueryPort)와 persistence adapter(adapter/out/persistence/RecommendSitePersistenceAdapter) 및 JPA 리포지토리(RecommendSiteRepository)를 추가해 outbound 포트를 구현했습니다.service와infrastructure패키지 내 구현(RecommendSiteService,RecommedSiteRepository)은 제거하여 새 계층으로 대체했습니다.RecommendSiteServiceTest를 추가해 최대 9개 제한 및 9개 이하일 때 전체 반환 동작을 명세했습니다.Testing
linkmind/src/test/java/com/app/toaster/recommendsite/application/RecommendSiteServiceTest.java를 추가했습니다.cd linkmind && ./gradlew test --tests "com.app.toaster.recommendsite.application.RecommendSiteServiceTest"이며 테스트 실행은 환경의 Gradle/Java 호환성 문제로 실패했습니다 (오류:Unsupported class file major version 69).RecommendSiteServiceTest가 정상 실행되면 기존 동작(최대 9개 제한)이 검증됩니다.Codex Task