Adopt width to min-width and changed height to auto to fit the width#3
Open
forgeOneHQ wants to merge 1 commit intoLinkStackOrg:mainfrom
Open
Adopt width to min-width and changed height to auto to fit the width#3forgeOneHQ wants to merge 1 commit intoLinkStackOrg:mainfrom
forgeOneHQ wants to merge 1 commit intoLinkStackOrg:mainfrom
Conversation
Author
|
Link to issue. |
Author
|
Shall the readme.md also be updated to increase the minor version with this change? |
Closed
Member
Yes, please up the version number by one. |
JulianPrieber
requested changes
Apr 5, 2024
Member
|
I believe this theme is based on this one: https://github.com/linkstackorg/Magic-Kingdom. Might be worth checking how it's solved there |
Author
|
There are differences in the code by the share.button.css too. The whole info is missing. I personally prefer the solution I build for our instance, I will check later when I have more time to fix it. But that fix makes it usable for the moment for everyone on mobile who is using it. |
Contributor
|
Check out #4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


The design of the buttons are not mobile friendly at the moment.
To make it suitable for smartphones I adopt the brands.css file and changed the lines:
width: 500px;
height 48;
to
min-width: 320px; (looks fine on google pixel 7 and IPhone SE)
height: auto; (To grow with the width and the text automatically)