Skip to content

Fix pin and photo subject migration jobs#1063

Merged
Toastbrot236 merged 9 commits intoLittleBigRefresh:mainfrom
Toastbrot236:w-again
Apr 1, 2026
Merged

Fix pin and photo subject migration jobs#1063
Toastbrot236 merged 9 commits intoLittleBigRefresh:mainfrom
Toastbrot236:w-again

Conversation

@Toastbrot236
Copy link
Copy Markdown
Contributor

This does a few fixes/adjustments for existing migration jobs:

  • Deleting entities during a migration job will now cause the job state to be adjusted, fixing an issue where CorrectWebsitePinProgressPlatformMigration would never be marked as complete (and possibly also unintentionally skip pins) if there were more than 1000 pins to migrate (the job was also renamed for consistency + to allow it to fully retry on instances where it has already been executed), and to allow similar jobs in the future to also run properly
  • MoveSubjectsOutOfGamePhotosMigration will not try to migrate photos again if they already have associated GamePhotoSubjects, avoiding duplicate key insertions
  • Some migration job-exclusive code was moved from Refresh.Database to the jobs' Migrate() method, to not keep methods only used by one specific job there

@Toastbrot236 Toastbrot236 merged commit 5f7e4a9 into LittleBigRefresh:main Apr 1, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants