Skip to content

feat: upgrade to node 24 + migrate to bun#65

Merged
LouisBrunner merged 9 commits intomainfrom
feat/n24
Mar 22, 2026
Merged

feat: upgrade to node 24 + migrate to bun#65
LouisBrunner merged 9 commits intomainfrom
feat/n24

Conversation

@LouisBrunner
Copy link
Owner

No description provided.

@LouisBrunner LouisBrunner requested a review from Copilot March 22, 2026 18:01
@LouisBrunner LouisBrunner self-assigned this Mar 22, 2026
@github-actions
Copy link

Smart Diff (Fails): Failure

Expected tolerance same but got worse instead

===================================================================
--- fixtures/file1_basic.txt
+++ fixtures/file2_deleted.txt
@@ -1,4 +1,3 @@
 A
-B
 C
 D

@github-actions
Copy link

Smart Diff (Works (sticky)): Success

Check succeeded with tolerance better (expected same or better)

===================================================================
--- fixtures/file1_basic.txt
+++ fixtures/file4_added.txt
@@ -1,4 +1,5 @@
 A
 B
 C
 D
+E

@github-actions
Copy link

Smart Diff (Works): Success

Check succeeded with tolerance better (expected same or better)

===================================================================
--- fixtures/file1_basic.txt
+++ fixtures/file4_added.txt
@@ -1,4 +1,5 @@
 A
 B
 C
 D
+E

@github-actions
Copy link

Smart Diff (Fails (sticky)): Failure

Expected tolerance same but got worse instead

===================================================================
--- fixtures/file1_basic.txt
+++ fixtures/file2_deleted.txt
@@ -1,4 +1,3 @@
 A
-B
 C
 D

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Upgrades the GitHub Action’s runtime/tooling toward Node 24 and switches the project build/test workflow from npm/Jest/ncc to Bun + Biome 2.

Changes:

  • Migrate CI to Bun (install, test, pack) and replace ncc packaging with bun build generating dist/index.js
  • Update Action metadata to run on node24 and modernize dependency versions / Biome configuration
  • Add a workflow to maintain “aggregate” tags (e.g., v1 pointing to latest v1.x)

Reviewed changes

Copilot reviewed 10 out of 16 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/processing.ts Reorders returned fields and ensures diff output is included in the result object.
src/notifications.ts Refactors GitHub Actions context typing/import and reorders API payload fields.
src/inputs.ts Reorders object literal fields for notifications and returned args.
package.json Switches scripts/tooling to Bun; updates dependencies and removes Jest/ncc.
biome.json Updates to Biome v2 schema/config and excludes dist/index.js from formatting/linting.
action.yml Updates action metadata formatting and runtime to node24.
tests/main.test.ts Adapts tests for new build artifact location and minor refactors.
.github/workflows/update-tags.yaml Adds a tagging workflow to update major/minor aggregate tags.
.github/workflows/build.yml Replaces setup-node/npm with setup-bun/bun commands.
.github/dependabot.yaml Updates formatting and switches dependency ecosystem monitoring to Bun.
Comments suppressed due to low confidence (1)

tests/main.test.ts:1

  • The test harness asserts outputs via ::set-output, which is deprecated and not how outputs are produced on actual runners when GITHUB_OUTPUT is set (file-based). Consider updating the tests to point process.env.GITHUB_OUTPUT to a temp file and assert by reading/parsing that file, so tests match real GitHub Actions behavior more closely.`
import * as cp from "node:child_process";

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

Smart Diff (Fails): Failure

Expected tolerance same but got worse instead

===================================================================
--- fixtures/file1_basic.txt
+++ fixtures/file2_deleted.txt
@@ -1,4 +1,3 @@
 A
-B
 C
 D

@github-actions
Copy link

Smart Diff (Works): Success

Check succeeded with tolerance better (expected same or better)

===================================================================
--- fixtures/file1_basic.txt
+++ fixtures/file4_added.txt
@@ -1,4 +1,5 @@
 A
 B
 C
 D
+E

@github-actions
Copy link

Smart Diff (Works): Success

Check succeeded with tolerance better (expected same or better)

===================================================================
--- fixtures/file1_basic.txt
+++ fixtures/file4_added.txt
@@ -1,4 +1,5 @@
 A
 B
 C
 D
+E

@github-actions
Copy link

Smart Diff (Fails): Failure

Expected tolerance same but got worse instead

===================================================================
--- fixtures/file1_basic.txt
+++ fixtures/file2_deleted.txt
@@ -1,4 +1,3 @@
 A
-B
 C
 D

@github-actions
Copy link

Smart Diff (Works): Success

Check succeeded with tolerance better (expected same or better)

===================================================================
--- fixtures/file1_basic.txt
+++ fixtures/file4_added.txt
@@ -1,4 +1,5 @@
 A
 B
 C
 D
+E

@github-actions
Copy link

Smart Diff (Fails): Failure

Expected tolerance same but got worse instead

===================================================================
--- fixtures/file1_basic.txt
+++ fixtures/file2_deleted.txt
@@ -1,4 +1,3 @@
 A
-B
 C
 D

@github-actions
Copy link

Smart Diff (Fails): Failure

Expected tolerance same but got worse instead

===================================================================
--- fixtures/file1_basic.txt
+++ fixtures/file2_deleted.txt
@@ -1,4 +1,3 @@
 A
-B
 C
 D

@github-actions
Copy link

Smart Diff (Works): Success

Check succeeded with tolerance better (expected same or better)

===================================================================
--- fixtures/file1_basic.txt
+++ fixtures/file4_added.txt
@@ -1,4 +1,5 @@
 A
 B
 C
 D
+E

@sonarqubecloud
Copy link

@LouisBrunner LouisBrunner merged commit ab382b4 into main Mar 22, 2026
36 of 85 checks passed
@LouisBrunner LouisBrunner deleted the feat/n24 branch March 22, 2026 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants