-
Notifications
You must be signed in to change notification settings - Fork 748
MAINT: Replace deprecated numpy assertions in coordinates/base.py #5156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
MAINT: Replace deprecated numpy assertions in coordinates/base.py #5156
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello there first time contributor! Welcome to the MDAnalysis community! We ask that all contributors abide by our Code of Conduct and that first time contributors introduce themselves on GitHub Discussions so we can get to know you. You can learn more about participating here. Please also add yourself to package/AUTHORS as part of this PR.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5156 +/- ##
========================================
Coverage 92.72% 92.72%
========================================
Files 180 180
Lines 22457 22472 +15
Branches 3186 3188 +2
========================================
+ Hits 20823 20837 +14
Misses 1177 1177
- Partials 457 458 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi! The Windows test failed in |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
e89e29e to
26727b5
Compare
Fixes #3743
Changes made in this Pull Request:
assert_almost_equalandassert_array_almost_equalwithassert_allcloseintestsuite/MDAnalysisTests/coordinates/base.py.atol=10**(-decimal)andrtol=0to maintain original test strictness.package/AUTHORS.PR Checklist
package/CHANGELOGfile updated?package/AUTHORS?Documentation preview : https://mdanalysis--5156.org.readthedocs.build/en/5156/