Fix #15: Resolve memory usage, error handling, and checkpointing issues in JetNet GNN pipeline#18
Open
Apprentice2907 wants to merge 2 commits intoML4SCI:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR addresses all issues mentioned in #15 by improving memory efficiency, adding checkpoint functionality, enhancing error tracking, and making hyperparameters configurable.
Issues Fixed
Fixes #15
Changes Made
1. Memory Optimization
max_jetsfrom 50,000 to 3,200 (default)Configclass for easy adjustment2. Enhanced Error Handling
collect_graph_and_targets()no_valid_particles,graph_construction_failed)3. Checkpoint System
Checkpoint files:
checkpoints/autoencoder_epoch_*.ptcheckpoints/diffusion_epoch_*.ptcheckpoints/embeddings.npycheckpoints/*_final.pth4. Configurable Hyperparameters
All hyperparameters moved to
Configclass:Example:
Testing
Files Changed
code.py- Main pipeline with all fixes appliedAdditional Notes