Skip to content

fix: fixes unit_size not working in Axes (#2336) and Surprising axis.__init__ default values (#2479)#4647

Open
csoapyhands-gif wants to merge 6 commits intoManimCommunity:mainfrom
csoapyhands-gif:polarTest
Open

fix: fixes unit_size not working in Axes (#2336) and Surprising axis.__init__ default values (#2479)#4647
csoapyhands-gif wants to merge 6 commits intoManimCommunity:mainfrom
csoapyhands-gif:polarTest

Conversation

@csoapyhands-gif
Copy link
Copy Markdown

@csoapyhands-gif csoapyhands-gif commented Mar 20, 2026

Overview: What does this pull request change?

Changes the .__init__() method for axis in the following manner:

  • Initially, x_length and y_length are set to None (previously, they were set to round(config.frame_width) - 2)
  • If any values for unit_size are passed in x_axis_config or y_axis_config, the necessary length value uses that value.
  • Otherwise, the length is set to the default value of round(config.frame_width) - 2.

Motivation and Explanation: Why and how do your changes improve the library?

Links to added or changed documentation pages

https://manimce--4647.org.readthedocs.build/en/4647

Further Information and Comments

This is my first contribution, so please feel free to give feedback!
Have a good day :)

Reviewer Checklist

  • The PR title is descriptive enough for the changelog, and the PR is labeled correctly
  • If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
  • If applicable: newly added functions and classes are tested

@csoapyhands-gif csoapyhands-gif changed the title fix: fixes unit_size not working in Axes (#2336) and Suprising axis.__init__ default values (#2479) fix: fixes unit_size not working in Axes (#2336) and Surprising axis.__init__ default values (#2479) Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant