feat: add flag to disable rendering for mobjects#4649
Open
maejam wants to merge 1 commit intoManimCommunity:mainfrom
Open
feat: add flag to disable rendering for mobjects#4649maejam wants to merge 1 commit intoManimCommunity:mainfrom
maejam wants to merge 1 commit intoManimCommunity:mainfrom
Conversation
Similar to ManimCommunity#2172 for cairo renderer. Mobjects flagged with `should_render=False` will not be rendered.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #2172 for cairo renderer.
Mobjects flagged with
should_render=Falsewill not be rendered.Overview: What does this pull request change?
Any Mobject can be flagged with the boolean attribute
should_render. When set toFalse, the Mobject will not be rendered.Motivation and Explanation: Why and how do your changes improve the library?
It gives more flexibility for users to control Mobjects visibility. For instance, when a Mobject is added to a VGroup that is itself added to the scene, it has 2 consequences: the Mobject is transformed with the Group and is made visible with it. This PR makes it possible to separate those 2 consequences.
See https://discord.com/channels/1453870851807117363/1453897466884784333/threads/1481607827884605545 for an in-depth discussion.
It also adds consistency between the 2 renderers by mimicking the PR linked above.
Links to added or changed documentation pages
Further Information and Comments
Reviewer Checklist