Rename space out submobjects#4654
Open
GoThrones wants to merge 10 commits intoManimCommunity:mainfrom
Open
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Member
|
No strong opinion on this, would like to hear what other maintainers think. The length of a method name usually isn't a great reason for introducing a breaking change. |
Contributor
Author
|
Actually, iirc, space_out_submobjects is not used by any other method/function in mainmce. Does changing it's name still constitute a breaking change ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
Name of the method was unnecessarily long. I've shortened it to space_out. It's intuitive to remember that a person wants to space out the constituents of a mobject.
Edit: The method "space_out_submobjects" is not used anywhere else in the source code.
Reviewer Checklist