Skip to content

Rename space out submobjects#4654

Open
GoThrones wants to merge 10 commits intoManimCommunity:mainfrom
GoThrones:rename-space-out-submobjects
Open

Rename space out submobjects#4654
GoThrones wants to merge 10 commits intoManimCommunity:mainfrom
GoThrones:rename-space-out-submobjects

Conversation

@GoThrones
Copy link
Copy Markdown
Contributor

@GoThrones GoThrones commented Mar 25, 2026

Overview: What does this pull request change?

Name of the method was unnecessarily long. I've shortened it to space_out. It's intuitive to remember that a person wants to space out the constituents of a mobject.

Edit: The method "space_out_submobjects" is not used anywhere else in the source code.

Reviewer Checklist

  • The PR title is descriptive enough for the changelog, and the PR is labeled correctly
  • If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
  • If applicable: newly added functions and classes are tested

@behackl
Copy link
Copy Markdown
Member

behackl commented Mar 26, 2026

No strong opinion on this, would like to hear what other maintainers think. The length of a method name usually isn't a great reason for introducing a breaking change.

@GoThrones
Copy link
Copy Markdown
Contributor Author

GoThrones commented Mar 27, 2026

Actually, iirc, space_out_submobjects is not used by any other method/function in mainmce. Does changing it's name still constitute a breaking change ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants