change Version to only have pointer receivers#240
Open
grosser wants to merge 1 commit intoMasterminds:masterfrom
Open
change Version to only have pointer receivers#240grosser wants to merge 1 commit intoMasterminds:masterfrom
grosser wants to merge 1 commit intoMasterminds:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
only gotcha I saw could be Metadata which use to return a copy of the metadata and now returns the metadata of the version so if anyone used that and then modified it they'd get unexpected results
docs say
// Metadata returns the metadata on the version.which is still correct 🤷... so lmk if you want to return a copy of the metadata or keep as is
fixes #237