Skip to content

Fixes form error + hint when friend request sent #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Rgoplay wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixes form error + hint when friend request sent #284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dac2cc1
Fixes creating invisible scroll on form error
Rgoplay Feb 17, 2026
9105354
Reverting overflow change, final fix
Rgoplay Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/webpage/direct.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,6 +319,7 @@ class Direct extends Guild {
const box = text.input.deref();
if (!box) return;
box.value = "";
box.placeholder = I18n.friends.requestsent();
}
},
{
Expand Down
3 changes: 2 additions & 1 deletion src/webpage/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4427,7 +4427,7 @@ fieldset input[type="radio"] {
.suberrora {
background: var(--channel-hover);
border-radius: 0.1in;
position: absolute;
position: relative;
Copy link
Owner

@MathMan05 MathMan05 Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is it being switched from absolute to relative?

Copy link
Contributor Author

@Rgoplay Rgoplay Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because when absolute, there is no space created for the error message, and it create scrolling (as the area is too small contain the error message). So the message become "hidden" behind the scroll. When relative, a space is created so elements below are moved but it doesn't create a scrollable area.

Copy link
Owner

@MathMan05 MathMan05 Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

won't that make layout shifts then?

Copy link
Contributor Author

@Rgoplay Rgoplay Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes unfortunately, but I think that's better than just not seeing the error.
I don't really know how to make it better

border: solid var(--primary-text) 0.02in;
color: color-mix(in hsl, var(--yellow), var(--red));
font-weight: bold;
Expand All @@ -4442,6 +4442,7 @@ fieldset input[type="radio"] {
box-sizing: border-box;
pointer-events: none;
z-index: 10000000;
width: fit-content;
}
@keyframes goout {
0%,
Expand Down
3 changes: 2 additions & 1 deletion translations/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,6 +263,7 @@
"friends": {
"addfriend": "Add friend",
"addfriendpromt": "Add friends by username:",
"requestsent": "Request sent!",
"all": "All",
"all:": "All friends:",
"blocked": "Blocked",
Expand Down Expand Up @@ -846,7 +847,7 @@
"title": "Stickers",
"upload": "Upload stickers"
},
"submit": "submit",
"submit": "Submit",
"switchAccounts": "Switch accounts ⇌",
"todayAt": "Today at $1",
"trace": {
Expand Down