Address "pending changes on server..." in copy mode https://github.com/MerginMaps/media-sync/issues/21 #44
Open
Ojaybee wants to merge 15 commits intoMerginMaps:mainfrom
Open
Address "pending changes on server..." in copy mode https://github.com/MerginMaps/media-sync/issues/21 #44Ojaybee wants to merge 15 commits intoMerginMaps:mainfrom
Ojaybee wants to merge 15 commits intoMerginMaps:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the “Pending changes on server…” issue described in #21
This change introduces a temporary working directory populated using hard links. Hard links are explicitly broken for non-media files (e.g. .mergin directory, GeoPackage files) to prevent modification of original data.
If the Mergin Maps server project version changes between the pull and push phases, the temporary working directory is discarded and the daemon retries the sync on the next cycle instead of failing.
The fix currently applies to copy mode only.
Changes from #40 are included to improve logging and facilitate testing and validation of the new behaviour.