Fixed color selection for map sketching #4274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Withalion
requested changes
Dec 23, 2025
Contributor
Withalion
left a comment
Withalion
left a comment
There was a problem hiding this comment.
Now it's probably a good time to create component out of the solutions in MMSketchesDrawer.qml and MMFormPhotoSketchingPageDialog.qml.
📦 Build Artifacts Ready
|
Withalion
reviewed
Jan 9, 2026
Contributor
Withalion
left a comment
Withalion
left a comment
There was a problem hiding this comment.
There is some additional work that needs to be done before we can proceed further
📦 Build Artifacts Ready
|
Withalion
reviewed
Jan 19, 2026
Contributor
Withalion
left a comment
Withalion
left a comment
There was a problem hiding this comment.
Looks much nicer
Side note: I was able to scroll the colors without any issues on android, but it doesn't work at all on desktop.
Withalion
reviewed
Jan 19, 2026
📦 Build Artifacts Ready
|
tomasMizera
requested changes
Jan 21, 2026
📦 Build Artifacts Ready
|
Collaborator
|
@gabriel-bolbotina please update the PR description how your changes look in the app |
tomasMizera
requested changes
Jan 27, 2026
Contributor
Author
@tomasMizera Updated the video |
📦 Build Artifacts Ready
|
📦 Build Artifacts Ready
|
Withalion
reviewed
Jan 29, 2026
📦 Build Artifacts Ready
|
Implemented figma design Added Redo and Eraser functionalities for the map sketching
Addressed review findings
gabriel-bolbotina
force-pushed
the
fix/color-picker-editing
branch
from
969d7b5 to
0a4ecb0
Compare
Pull Request Test Coverage Report for Build 21581303652Details
💛 - Coveralls |
📦 Build Artifacts Ready
|
Withalion
approved these changes
Jan 30, 2026
tomasMizera
approved these changes
Jan 30, 2026
Collaborator
tomasMizera
left a comment
tomasMizera
left a comment
There was a problem hiding this comment.
The attached video shows that the redo button jumps between visible/invisible states. I can not see it in the code though so I hope that it is just an outdated video. The code suggests that redo is just disabled (not hidden) when canRedo is false, and I think that is correct ux-wise.
Contributor
Author
In that video that was the behaviour before the figma design was updated. I modified it so that it works with the updated design. I will update the video as well. |
📦 Build Artifacts Ready
|
Collaborator
|
Let's proceed with testing :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the components inside the MMSKetchesDrawer.
Below there is the latest UI:
updated-video-latest.mov