This repository was archived by the owner on Oct 16, 2025. It is now read-only.
tests: Cover rejection of pending getLatestBlock requests when blocker tracker is destroyed#322
Merged
cryptodev-2s merged 2 commits intomainfrom May 28, 2025
Conversation
…k tracker is destroyed
cryptodev-2s
force-pushed
the
fix/reject-pending-latest-block-on-stop-add-test
branch
from
f2b261d to
20555c7
Compare
Gudahtt
reviewed
May 28, 2025
cryptodev-2s
changed the title
getLatestBlock requests when blocker tracker is destroyedgetLatestBlock requests when blocker tracker is destroyed
mcmire
approved these changes
May 28, 2025
Contributor
mcmire
left a comment
mcmire
left a comment
There was a problem hiding this comment.
One nit, but LGTM otherwise.
| expect(blockTracker.getCurrentBlock()).toBe('0x0'); | ||
| expect(blockTracker.isRunning()).toBe(true); | ||
|
|
||
| // Clear the current block to force a new request for the next getLatestBlock |
Contributor
There was a problem hiding this comment.
Nit: This comment should probably read:
Suggested change
| // Clear the current block to force a new request for the next getLatestBlock | |
| // Stop the block tracker. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new test case to confirm rejection of pending
getLatestBlockrequests when blocker tracker is destroyed