Skip to content

Fix FilterUrlBuilder if pageModel not null#1557

Open
zonky2 wants to merge 3 commits intohotfix/2.4.16from
hotfix/fix_filter_url_builder
Open

Fix FilterUrlBuilder if pageModel not null#1557
zonky2 wants to merge 3 commits intohotfix/2.4.16from
hotfix/fix_filter_url_builder

Conversation

@zonky2
Copy link
Copy Markdown
Contributor

@zonky2 zonky2 commented Apr 15, 2026

No description provided.

@zonky2 zonky2 self-assigned this Apr 15, 2026
@zonky2 zonky2 added this to the 2.4.x milestone Apr 15, 2026
@zonky2 zonky2 changed the title Fix FilterUrlBuilder if pageModel not null [WIP] Fix FilterUrlBuilder if pageModel not null Apr 15, 2026
@discordier
Copy link
Copy Markdown
Member

@zonky2, @MacKP What was missing in here?
Only the tests or was there more?
Regarding the tests, what was the expected outcome?

@zonky2
Copy link
Copy Markdown
Contributor Author

zonky2 commented Apr 29, 2026

@discordier We’ve put the rework on hold because the unit tests have raised some uncertainties regarding the implementation – don’t merge the PR; it’s your call ^^

@zonky2 zonky2 requested a review from discordier April 29, 2026 05:27
@zonky2 zonky2 added the bug A bug! A bug! Fast, squish it! label Apr 29, 2026
@zonky2 zonky2 changed the title [WIP] Fix FilterUrlBuilder if pageModel not null Fix FilterUrlBuilder if pageModel not null May 5, 2026
@MacKP
Copy link
Copy Markdown
Contributor

MacKP commented May 6, 2026

Fix is working in my case.

Copy link
Copy Markdown
Member

@discordier discordier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, fingers crossed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug A bug! A bug! Fast, squish it!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants