Open
Conversation
Owner
|
Thanks for your contribution! I am checking the pull request. It seems that you modified the indentations so it is hard to see the actual changes of the code since most of the lines are labeled as differences. |
Author
|
Thanks for your feedback. I will fix the indentation and create a new pull request. |
Owner
|
@iamrishab It seems that the char maps are wrongly localized with the current PR. |
Author
|
@MhLiao |
Author
|
@MhLiao will you be able to merge this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed test issue with TEST.IMS_PER_BATCH greater than 1