Skip to content

bump CSTParser version#4

Merged
MikeInnes merged 1 commit intoMikeInnes:masterfrom
aviatesk:bumpcstparser
Feb 10, 2020
Merged

bump CSTParser version#4
MikeInnes merged 1 commit intoMikeInnes:masterfrom
aviatesk:bumpcstparser

Conversation

@aviatesk
Copy link
Contributor

@aviatesk aviatesk commented Feb 9, 2020

CSTParser@1.1.0 was fairly breaking but it just removes meta information of EXPR.binding and EXPR.scope, which SourceWalk doesn't uses, so we can just bump up the version :)

@MikeInnes
Copy link
Owner

Don't we already support 1.1 by supporting 1? Adding 2 seems like it's going to claim support for a release that doesn't exist yet.

@aviatesk
Copy link
Contributor Author

Actually there was already CSTParser≥2, which was tagged as a kind of "band-aid" since 1.1 was really breaking (e.g. for Atom.jl: JunoLab/Atom.jl#262).
Since SourceWalk is not affected by the changes introduced in 1.1, I would like to bump it (I will use this package in Atom.jl which is now compatible with CSTParser≥2: JunoLab/Atom.jl#203)

@MikeInnes
Copy link
Owner

Can you link the PR where CSTParser 2 was tagged?

@aviatesk
Copy link
Contributor Author

Here you are: JuliaRegistries/General#6197

@MikeInnes
Copy link
Owner

Ok thanks. I see what you mean now so I think we can merge. Thanks for the patch!

@MikeInnes MikeInnes merged commit 10edbd4 into MikeInnes:master Feb 10, 2020
@aviatesk aviatesk deleted the bumpcstparser branch February 10, 2020 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants