Skip to content

GEOPY-2623: colour for Curve is not working the same way as other objects#827

Merged
domfournier merged 5 commits intodevelopfrom
GEOPY-2623
Jan 7, 2026
Merged

GEOPY-2623: colour for Curve is not working the same way as other objects#827
domfournier merged 5 commits intodevelopfrom
GEOPY-2623

Conversation

@MatthieuCMira
Copy link
Copy Markdown
Contributor

@MatthieuCMira MatthieuCMira commented Dec 19, 2025

GEOPY-2623 - colour for Curve is not working the same way as other objects
fix the visual parameter bug for curve and surface

@github-actions github-actions Bot changed the title GEOPY-2623 GEOPY-2623: colour for Curve is not working the same way as other objects Dec 19, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 19, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 91.08%. Comparing base (5849378) to head (46b6293).
⚠️ Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
geoh5py/data/visual_parameters.py 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #827      +/-   ##
===========================================
+ Coverage    91.07%   91.08%   +0.01%     
===========================================
  Files          115      115              
  Lines        10119    10121       +2     
  Branches      1877     1878       +1     
===========================================
+ Hits          9216     9219       +3     
+ Misses         481      480       -1     
  Partials       422      422              
Files with missing lines Coverage Δ
geoh5py/__init__.py 55.55% <ø> (ø)
geoh5py/data/__init__.py 100.00% <ø> (ø)
geoh5py/data/blob_data.py 66.66% <ø> (ø)
geoh5py/data/boolean_data.py 100.00% <ø> (ø)
geoh5py/data/color_map.py 92.15% <ø> (ø)
geoh5py/data/colour.py 98.30% <ø> (ø)
geoh5py/data/data.py 90.78% <ø> (ø)
geoh5py/data/data_association_enum.py 100.00% <ø> (ø)
geoh5py/data/data_type.py 94.63% <ø> (ø)
geoh5py/data/data_unit.py 66.66% <ø> (ø)
... and 105 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

benk-mira
benk-mira previously approved these changes Dec 19, 2025
Comment thread geoh5py/data/visual_parameters.py Outdated
Comment thread geoh5py/data/visual_parameters.py Outdated
Comment thread tests/visual_parameters_test.py
add grid2d for test
domfournier
domfournier previously approved these changes Jan 7, 2026
@domfournier domfournier merged commit 907c874 into develop Jan 7, 2026
17 checks passed
@domfournier domfournier deleted the GEOPY-2623 branch January 7, 2026 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants