Improve Font Icon Set name assignment #1077
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… it was set Now, we pass the font asset in explicitly from the serialization
We don't need the extra menu stuff provided by BeginFoldoutHeaderGroup
More icons on screen at once!
keveleigh
force-pushed
the
new-icon-naming
branch
from
f4e79db to
c27d346
Compare
keveleigh
force-pushed
the
new-icon-naming
branch
from
c27d346 to
ac67238
Compare
keveleigh
force-pushed
the
new-icon-naming
branch
from
ac67238 to
3d3ab91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_Colorto_FaceColor)DrawFontGlyphsGridwas trying to read an entry from the deserialized Font Icon Set when the entry had only just been written to the serialized representation and wasn't yet updatedTODO before un-drafting: Migration path from the current "Icon #" names
From this:
to this:
