Fix: keep voice playback running when screen locks#6097
Open
SeniorZhai wants to merge 2 commits intomasterfrom
Open
Fix: keep voice playback running when screen locks#6097SeniorZhai wants to merge 2 commits intomasterfrom
SeniorZhai wants to merge 2 commits intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes an issue where voice playback would stop when the screen locks or when the app authentication screen appears. The fix ensures audio continues playing in these scenarios.
Changes:
- Updated the audio pause logic in
ConversationFragment.onPause()to also check if the app authentication screen is being shown - Set the
appAuthShownflag earlier in the authentication flow (incheckAndShowAppAuthmethod) to ensure proper state tracking before the authentication activity starts
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| app/src/main/java/one/mixin/android/ui/conversation/ConversationFragment.kt | Modified audio pause condition to check for app authentication screen in addition to screen lock |
| app/src/main/java/one/mixin/android/MixinApplication.kt | Added appAuthShown = true before showing the authentication activity to ensure the flag is set early |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| override fun onPause() { | ||
| // don't stop audio player if triggered by screen off | ||
| if (powerManager.isInteractive) { | ||
| // don't stop audio player if triggered by screen off or app lock overlay |
There was a problem hiding this comment.
The comment refers to "app lock overlay" but AppAuthActivity is a separate activity, not an overlay. Consider updating the comment to say "app lock screen" or "app authentication" for accuracy.
Suggested change
| // don't stop audio player if triggered by screen off or app lock overlay | |
| // don't stop audio player if triggered by screen off or app lock screen |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.