Opt/landing carousel by SeniorZhai · Pull Request #6102 · MixinNetwork/android-app

SeniorZhai · 2026-01-29T06:06:45Z

No description provided.

…le-reminder

Copilot

Pull request overview

This pull request implements a landing page carousel feature with multiple UI improvements and refactoring of the PIN setup flow.

Changes:

Added a new landing page carousel showcasing Mixin features with auto-scrolling and indicators
Refactored PIN setup and creation logic by extracting shared code into TipFlowInteractor and TipCreateInteractor
Implemented mobile verification reminder functionality with a 60-day verification interval

Reviewed changes

Copilot reviewed 55 out of 56 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
app/src/main/res/values/strings.xml	Added numerous string resources for carousel features, PIN setup, mobile verification, and mnemonic phrase instructions
app/src/main/res/values-zh-rTW/strings.xml	Added Traditional Chinese translations for new carousel and landing features
app/src/main/res/values-zh-rCN/strings.xml	Added Simplified Chinese translations for new carousel and landing features
app/src/main/res/layout/item_landing_feature.xml	New layout file for individual carousel items with image, title, and description
app/src/main/res/layout/fragment_setup_name.xml	Redesigned name setup UI with centered layout and modern button style
app/src/main/res/layout/fragment_landing.xml	Replaced static logo with ViewPager2 for carousel and TabLayout for indicators
app/src/main/res/layout-v26/fragment_setup_name.xml	Deleted API 26+ specific layout variant to consolidate design
app/src/main/res/drawable/*.xml	Added multiple new drawable resources for carousel images, account features, and UI components
app/src/main/java/one/mixin/android/ui/tip/TipFragment.kt	Major refactoring extracting business logic to TipFlowInteractor
app/src/main/java/one/mixin/android/ui/tip/TipFlowInteractor.kt	New class containing extracted PIN creation/update logic from TipFragment
app/src/main/java/one/mixin/android/ui/tip/TipCreateInteractor.kt	New class for handling PIN creation specifically
app/src/main/java/one/mixin/android/ui/landing/SetupPinViewModel.kt	New ViewModel for PIN setup flow
app/src/main/java/one/mixin/android/ui/landing/components/SetPinPage.kt	Redesigned PIN setup page with numeric keypad
app/src/main/java/one/mixin/android/ui/landing/components/SetupPinPage.kt	Updated PIN setup page with error handling and retry functionality
app/src/main/java/one/mixin/android/ui/landing/components/QuizPage.kt	Enhanced quiz page with bottom sheet result display
app/src/main/java/one/mixin/android/ui/landing/LandingFragment.kt	Implemented carousel with feature items and auto-scrolling
app/src/main/java/one/mixin/android/ui/landing/LandingFeatureAdapter.kt	New adapter for landing page carousel
app/src/main/java/one/mixin/android/ui/landing/CreateAccountConfirmBottomSheetDialogFragment.kt	New bottom sheet for account creation confirmation
app/src/main/java/one/mixin/android/ui/wallet/PrivacyWalletFragment.kt	Added mobile verification check before buy action
app/src/main/java/one/mixin/android/ui/wallet/ClassicWalletFragment.kt	Added mobile verification check before buy action
app/src/main/java/one/mixin/android/ui/home/ConversationListFragment.kt	Added verification reminder display logic
app/src/main/java/one/mixin/android/Constants.kt	Added INTERVAL_60_DAYS constant

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-05T07:16:30Z

app/src/main/java/one/mixin/android/ui/landing/components/SetPinPage.kt

-                    modifier = Modifier.align(Alignment.CenterHorizontally),
-                    stringResource(R.string.More_Information),
+                    text = if (!isConfirmStep) {
+                        stringResource(R.string.Set_up_pin_desc_1)


The string resource "set_up_pin_desc_1" is referenced in SetPinPage.kt but not defined in strings.xml. This will cause a runtime crash when trying to display this text.

Suggested change

stringResource(R.string.Set_up_pin_desc_1)

"Set up your PIN"

Copilot · 2026-02-05T07:16:30Z

app/src/main/java/one/mixin/android/ui/landing/components/SetPinPage.kt

+                    text = if (!isConfirmStep) {
+                        stringResource(R.string.Set_up_pin_desc_1)
+                    } else {
+                        stringResource(R.string.Set_up_pin_desc_2)


The string resource "set_up_pin_desc_2" is referenced in SetPinPage.kt but not defined in strings.xml. This will cause a runtime crash when trying to display this text.

Suggested change

stringResource(R.string.Set_up_pin_desc_2)

stringResource(R.string.Set_up_pin_desc_1)

Copilot · 2026-02-05T07:16:31Z

app/src/main/java/one/mixin/android/ui/landing/MobileFragment.kt

+    private fun applySafeTopPadding(rootView: View) {
+        val originalPaddingTop: Int = rootView.paddingTop
+        ViewCompat.setOnApplyWindowInsetsListener(rootView) { v: View, insets: WindowInsetsCompat ->
+            val topInset: Int = insets.getInsets(WindowInsetsCompat.Type.displayCutout()).top


In the window insets handling for LandingActivity, the wrong inset type is being used. The code uses WindowInsetsCompat.Type.displayCutout() instead of WindowInsetsCompat.Type.statusBars(). The displayCutout insets are for device notches and cutouts, while statusBars are for the system status bar which is what should typically be used for top padding. This is inconsistent with the implementation in VerificationFragment.kt (line 150) and WebFragment.kt (line 446) which correctly use statusBars.

Suggested change

val topInset: Int = insets.getInsets(WindowInsetsCompat.Type.displayCutout()).top

val topInset: Int = insets.getInsets(WindowInsetsCompat.Type.statusBars()).top

Copilot · 2026-02-05T07:16:31Z

app/src/main/java/one/mixin/android/ui/landing/LandingMnemonicPhraseFragment.kt

+    private fun applySafeTopPadding(rootView: View) {
+        val originalPaddingTop: Int = rootView.paddingTop
+        ViewCompat.setOnApplyWindowInsetsListener(rootView) { v: View, insets: WindowInsetsCompat ->
+            val topInset: Int = insets.getInsets(WindowInsetsCompat.Type.displayCutout()).top


In the window insets handling, the wrong inset type is being used. The code uses WindowInsetsCompat.Type.displayCutout() instead of WindowInsetsCompat.Type.statusBars(). This is inconsistent with other fragments like VerificationFragment.kt and WebFragment.kt which correctly use statusBars for top padding.

Suggested change

val topInset: Int = insets.getInsets(WindowInsetsCompat.Type.displayCutout()).top

val topInset: Int = insets.getInsets(WindowInsetsCompat.Type.statusBars()).top

Copilot · 2026-02-05T07:16:31Z

app/src/main/java/one/mixin/android/ui/landing/CreateAccountFragment.kt

+    private fun applySafeTopPadding(rootView: View) {
+        val originalPaddingTop: Int = rootView.paddingTop
+        ViewCompat.setOnApplyWindowInsetsListener(rootView) { v: View, insets: WindowInsetsCompat ->
+            val topInset: Int = insets.getInsets(WindowInsetsCompat.Type.displayCutout()).top


In the window insets handling, the wrong inset type is being used. The code uses WindowInsetsCompat.Type.displayCutout() instead of WindowInsetsCompat.Type.statusBars(). This is inconsistent with other fragments like VerificationFragment.kt and WebFragment.kt which correctly use statusBars for top padding.

Suggested change

val topInset: Int = insets.getInsets(WindowInsetsCompat.Type.displayCutout()).top

val topInset: Int = insets.getInsets(WindowInsetsCompat.Type.statusBars()).top

Copilot · 2026-02-05T07:16:32Z

app/src/main/java/one/mixin/android/ui/landing/MnemonicPhraseFragment.kt

+    private fun applySafeTopPadding(rootView: View) {
+        val originalPaddingTop: Int = rootView.paddingTop
+        ViewCompat.setOnApplyWindowInsetsListener(rootView) { v: View, insets: WindowInsetsCompat ->
+            val topInset: Int = insets.getInsets(WindowInsetsCompat.Type.displayCutout()).top


In the window insets handling, the wrong inset type is being used. The code uses WindowInsetsCompat.Type.displayCutout() instead of WindowInsetsCompat.Type.statusBars(). This is inconsistent with other fragments like VerificationFragment.kt and WebFragment.kt which correctly use statusBars for top padding.

Suggested change

val topInset: Int = insets.getInsets(WindowInsetsCompat.Type.displayCutout()).top

val topInset: Int = insets.getInsets(WindowInsetsCompat.Type.statusBars()).top

# Conflicts: # app/src/main/java/one/mixin/android/ui/tip/TipFragment.kt

# Conflicts: # app/src/main/java/one/mixin/android/ui/home/MainActivity.kt # app/src/main/java/one/mixin/android/ui/tip/TipFragment.kt

…ing_carousel # Conflicts: # app/src/main/java/one/mixin/android/ui/home/ConversationListFragment.kt # app/src/main/java/one/mixin/android/ui/landing/LandingActivity.kt # app/src/main/java/one/mixin/android/ui/landing/MobileFragment.kt # app/src/main/java/one/mixin/android/ui/landing/VerificationFragment.kt # app/src/main/java/one/mixin/android/ui/wallet/PrivacyWalletFragment.kt

# Conflicts: # app/src/main/java/one/mixin/android/ui/tip/TipFragment.kt

SeniorZhai added 12 commits January 19, 2026 14:43

feat: add verify-mobile reminder and gate wallet buy flow

edfc20a

Code clean

57f457e

Landing: refine feature carousel layout and rename resources

153569d

Merge remote-tracking branch 'origin/master' into opt/landing_carousel

b05c657

Merge remote-tracking branch 'origin/master' into feature/verify-mobi…

be8f47e

…le-reminder

Replace icon

adc68fb

Merge branch 'feature/verify-mobile-reminder' into opt/landing_carousel

62661d3

Update safe area

9c41848

Update setup pin

724b97a

Merge remote-tracking branch 'origin/master' into opt/landing_carousel

21800bc

Update create flow

0c6a0f2

Merge remote-tracking branch 'origin/master' into opt/landing_carousel

01a9bcb

SeniorZhai force-pushed the opt/landing_carousel branch from 600117b to 68f1af0 Compare February 3, 2026 06:29

Update account confirm

5091252

SeniorZhai force-pushed the opt/landing_carousel branch from 68f1af0 to 5091252 Compare February 3, 2026 06:38

SeniorZhai added 4 commits February 3, 2026 15:10

Update setup name

9ceeec5

Update UI

e594926

Update quiz page

77862b0

Update set pin flow

5af5cc3

SeniorZhai force-pushed the opt/landing_carousel branch from 1550d9b to 5af5cc3 Compare February 4, 2026 11:56

feat: Add 12/24 words option to mnemonic phrase input

2048c72

SeniorZhai force-pushed the opt/landing_carousel branch from f47a028 to 2048c72 Compare February 5, 2026 06:25

refactor: Restructure landing feature layou

be2eaa1

SeniorZhai requested a review from Copilot February 5, 2026 07:13

Copilot started reviewing on behalf of SeniorZhai February 5, 2026 07:13 View session

Copilot AI reviewed Feb 5, 2026

View reviewed changes

SeniorZhai added 4 commits February 5, 2026 15:22

Merge remote-tracking branch 'origin/master' into opt/landing_carousel

383d980

# Conflicts: # app/src/main/java/one/mixin/android/ui/tip/TipFragment.kt

Merge remote-tracking branch 'origin/master' into opt/landing_carousel

300339b

Open wallet on first entry

5f415f9

Update design

01c53e4

SeniorZhai force-pushed the opt/landing_carousel branch 2 times, most recently from fbde026 to 15e1b82 Compare February 10, 2026 11:52

Update strings, design

d19ede6

SeniorZhai force-pushed the opt/landing_carousel branch from 15e1b82 to d19ede6 Compare February 10, 2026 12:16

SeniorZhai marked this pull request as ready for review February 10, 2026 14:02

SeniorZhai added 4 commits February 10, 2026 22:07

Update analytics

212f8b4

Merge remote-tracking branch 'origin/master' into opt/landing_carousel

5b3b91f

# Conflicts: # app/src/main/java/one/mixin/android/ui/home/MainActivity.kt # app/src/main/java/one/mixin/android/ui/tip/TipFragment.kt

Update

21c64a8

Update strings

0f0ea14

SeniorZhai force-pushed the opt/landing_carousel branch from 2ca0b68 to 0f0ea14 Compare February 11, 2026 08:10

SeniorZhai added 6 commits February 11, 2026 16:40

Update design

c59b992

Update

3ec769d

Pop back stack

d7d715b

Merge remote-tracking branch 'origin/master' into opt/landing_carousel

564c136

Revert

2248a9c

SeniorZhai force-pushed the opt/landing_carousel branch from 5bc50de to 6ff8a08 Compare February 12, 2026 06:54

Update

4a69194

SeniorZhai force-pushed the opt/landing_carousel branch 2 times, most recently from 6dd79e5 to 4ef5ade Compare February 13, 2026 03:15

SeniorZhai added 2 commits February 13, 2026 20:16

Update

43afe66

Merge branch 'master' into opt/landing_carousel

69b9ae7

# Conflicts: # app/src/main/java/one/mixin/android/ui/tip/TipFragment.kt

SeniorZhai force-pushed the opt/landing_carousel branch from 4ef5ade to 69b9ae7 Compare February 13, 2026 12:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Opt/landing carousel#6102

Opt/landing carousel#6102
SeniorZhai wants to merge 37 commits intomasterfrom
opt/landing_carousel

SeniorZhai commented Jan 29, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 5, 2026

Uh oh!

Copilot AI Feb 5, 2026

Uh oh!

Copilot AI Feb 5, 2026

Uh oh!

Copilot AI Feb 5, 2026

Uh oh!

Copilot AI Feb 5, 2026

Uh oh!

Copilot AI Feb 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

	stringResource(R.string.Set_up_pin_desc_2)
	stringResource(R.string.Set_up_pin_desc_1)

	val topInset: Int = insets.getInsets(WindowInsetsCompat.Type.displayCutout()).top
	val topInset: Int = insets.getInsets(WindowInsetsCompat.Type.statusBars()).top

Comments

Conversation

SeniorZhai commented Jan 29, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant