Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
该 PR 为“表格 resize handles”增加了可配置开关,并在数学环境(如 align、矩阵等)中禁用表格 handles 的显示与交互,以满足定制化样式与数学排版场景下的编辑行为要求。
Changes:
- 新增环境变量
TABLE_HANDLES(默认true)用于控制是否显示/启用表格 handles - 在
draw_table_resize_handles中:当TABLE_HANDLES=false时不绘制 handles;当表格处于MODE=math时不绘制 handles - 增加开发说明文档(含测试步骤与实现说明)
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Typeset/Env/env_default.cpp | 为默认环境增加 TABLE_HANDLES=true |
| src/Edit/Interface/edit_repaint.cpp | 根据 TABLE_HANDLES 与 MODE=math 控制表格 handles 绘制逻辑 |
| moebius/moebius/vars.hpp | 声明新增环境变量 TABLE_HANDLES |
| moebius/moebius/vars.cpp | 定义新增环境变量名 "table-handles" |
| moebius/moebius/drd/drd_std.cpp | 在标准 DRD 中注册 TABLE_HANDLES 变量类型 |
| devel/201_79.md | 增加需求/测试/实现记录文档 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[201_80] 定制化表格handles显示
如何测试
样式->编辑样式),插入<assign|table-handles|false>后保存2026/2/9
What
在align环境等数学环境下的所有表格结构的组件,在编辑时,handles都应该不显示,也不应支持拖拽
How
vars.hpp、vars.cpp和env_default.cpp中添加TABLE_HANDLES环境变量,默认值为"true",表示表格handles默认显示edit_repaint.cpp中的repaint_table_handles函数中添加判断,如果当前表格所在环境的MODE环境变量值为"math",则不显示handles;如果TABLE_HANDLES环境变量值为"false",则始终不显示handles