Color links black with an underline on the homepage red hero#288
Open
Color links black with an underline on the homepage red hero#288
Conversation
strangeways
approved these changes
Oct 7, 2021
Contributor
strangeways
left a comment
strangeways
left a comment
There was a problem hiding this comment.
The _home-* styles are used only on the main home page, so this should be fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QA'd this by manually changing front-stage's importing of styles to:
wp_enqueue_style('giraffe', 'https://static.moveon.org/static/stylesheets/ilona-fix-links-on-red-bg.css', array(), $asset_ver);I'm guessing actionkit templates don't have the
home-hero-bg-redclass in them that this change is nested in but I still feel a little nervous. Any other tips on checking and qa-ing here?