Conversation
…880b130ff (2024.12.27 19:37:55) Updated ComfyUI-3D-Pack\nodes.py to match general flow. Pulled out some hidden parameters of TRELLIS sampler to UI.
…e creates new file every time instead of rewriting it. New output format option to select between [glb, ply, obj] instead of reading the file name extension. New "create_folder" option to create new directory for every output and put all files into the same place.
|
Great job! |
Updated `Trellis_Structured_3D_Latents_Models` so, if provided with batch of images, it will process in `run_multi_image` pipe. Cleanup in `nodes.py`.
True. I also made a little clean up in |
|
I just tested this PR and found some files that would be better left unchanged:
In addition, modifying the |
p.s. Gosh, markdown sometimes make me feel so miserable. |
|
@iiiCpu Hi, thank you for your contribution, I'll take a closer look later this week |
MrForExample
left a comment
MrForExample
left a comment
There was a problem hiding this comment.
Please clean up your change before I merge them
There was a problem hiding this comment.
What's the reason to remove comfy progressbar?
There was a problem hiding this comment.
Please remove some unnecessary changes and change it back to xformers, because xformers actually supports flash_attn
There was a problem hiding this comment.
Where in the code did you used the newly added function run_multi_image?
There was a problem hiding this comment.
Those change were mode to support xformer, please revert it back
There was a problem hiding this comment.
Please remove all the unnecessary files from flexicubes, this project is already big enough in size
There was a problem hiding this comment.
Please double check all the library you used, for example, kaolin notoriously is hard to install on Windows, thus I didn't use it in this project and replaced all the functions with customized function
There was a problem hiding this comment.
Can you please merge trelles_ with trelles, is hard to tell what is changed in trelles_, minimal change when ever possible please
4 participants
I had a problem with original Trellis pipeline on Windows 11 (wasted like 6 hours to make it work with no effect). So, I replaced it with Microsoft's one, which now works like charm. For me, I had to launch
microsoft/TRELLISapp.py, let it build all it needed to build, copy allmicrosoft/TRELLIS/trelliscontents intoComfyUI-3D-Pack/Gen_3D_Modules/TRELLIS/trellis.Also, I had to move some mesh postprocess code from
trellis.postprocessing_utilsintoTrellis_Structured_3D_Latents_Models.save_gsas I wanted to getMESHinstead of just saved file name.I also changed
Save_3D*nodes to act more like standardSave_Imagenode: to add index to a file name instead of replacing it. And I also made option to create entire folder, it's useful to save different formats or preview into the same place.