Skip to content

Comments

Makes withdrawing a request semantically distinct operation#588

Open
allanlasser wants to merge 11 commits intoallanlasser/issue571from
allanlasser/issue575
Open

Makes withdrawing a request semantically distinct operation#588
allanlasser wants to merge 11 commits intoallanlasser/issue571from
allanlasser/issue575

Conversation

@allanlasser
Copy link
Member

@allanlasser allanlasser commented Feb 12, 2026

Fixes #575

Previously, we conflated withdrawing a request with rejecting, which led to some unexpected behavior. This is now clearer, with a specific ability to understand what happened to a particular request.

Note: currently based on #582 to avoid migration merge conflicts. Should be rebased and merged following that change.

@allanlasser allanlasser requested a deployment to squarelet-pi-allanlasse-tjitm6 February 12, 2026 21:49 Abandoned
@allanlasser allanlasser linked an issue Feb 12, 2026 that may be closed by this pull request
@allanlasser allanlasser temporarily deployed to squarelet-pi-allanlasse-tjitm6 February 12, 2026 22:00 Inactive
@allanlasser allanlasser marked this pull request as ready for review February 13, 2026 15:33
@duckduckgrayduck
Copy link
Contributor

duckduckgrayduck commented Feb 13, 2026

I requested to join Allan test org, withdrew my invitation, but it still appears to to hide the Request to Join from me. Says "Your request to join this organization was rejected. Please contact an admin if this is a mistake and you need to be added to this organization"

@allanlasser
Copy link
Member Author

I requested to join Allan test org, withdrew my invitation, but it still appears to to hide the Request to Join from me. Says "Your request to join this organization was rejected. Please contact an admin if this is a mistake and you need to be added to this organization"

I'll have to double check our context data and template. Thanks for catching this!

@allanlasser allanlasser temporarily deployed to squarelet-pi-allanlasse-qyf9kp February 18, 2026 14:27 Inactive
@allanlasser allanlasser temporarily deployed to squarelet-pi-allanlasse-oo4vwi February 18, 2026 15:27 Inactive
@allanlasser allanlasser temporarily deployed to squarelet-pi-allanlasse-oo4vwi February 18, 2026 15:52 Inactive
@allanlasser
Copy link
Member Author

@duckduckgrayduck found the issue—I needed to update the form action from "reject" to "withdraw" in two locations. Should work as expected now!

@duckduckgrayduck
Copy link
Contributor

That is fixed, however the withdrawn request still appears in the list of pending requests at /organizations/ and under the "Open Requests" section of my profile I think because it is checking if these are rejected or accepted, not handling the withdrawn case.

@allanlasser
Copy link
Member Author

Great, fixed that one too—two missing lines in our User model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Withdrawing a request to join should withdraw it, not reject it

2 participants