Upgrade member_not_found integrity check from warning to error by default#1608
Open
jordanpadams wants to merge 3 commits into
Open
Upgrade member_not_found integrity check from warning to error by default#1608jordanpadams wants to merge 3 commits into
jordanpadams wants to merge 3 commits into
Conversation
Add --allow-unlisted-members flag to downgrade back to warning for accumulating/incremental bundle validation use cases. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…lt ERROR behavior - Add src/test/resources/features/4.2.x.feature with two scenarios: subtest 1: default run expects error.integrity.member_not_found=1 subtest 2: with --skip-strict-collection-membership expects warning.integrity.member_not_found=1 - Add minimal PDS4 bundle test data in src/test/resources/github1601/ to trigger member_not_found (collection inventory references a non-existent primary member) - Update pre.3.6.x.feature: add --skip-strict-collection-membership to four existing tests (github408/1, github401/1, github368/1, github6/2) that expected the old WARNING behavior, so they continue to pass with the new ERROR default Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Summary
warning.integrity.member_not_foundtoerror.integrity.member_not_found(ERROR severity) by default in bothBundleReferentialIntegrityRuleandCollectionReferentialIntegrityRule--allow-unlisted-members(and config keyvalidate.allowUnlistedMembers) that downgrades the condition back to a WARNING for users validating partial/accumulating bundles where prior-release products are intentionally absent--allow-unlisted-members🤖 AI Assistance: This PR was substantially developed with Claude Code assistance (~90% of changes).
⚙️ Test Data and/or Report
The behavior change can be verified manually:
validate --rule pds4.bundleagainst a bundle where a collection inventory references products not present in the target → previously producedWARNING [warning.integrity.member_not_found], now producesERROR [error.integrity.member_not_found]--allow-unlisted-members→ restores the originalWARNING [warning.integrity.member_not_found]behaviorAutomated test coverage should be added as a follow-on (test data scaffolding for github1601/).
♻️ Related Issues
Fixes #1601
Background context:
🤓 Reviewer Checklist
--allow-unlisted-memberssection added)FlagsUtil.initialize()resets the new flag tofalse, ensuring clean state between runs