minor modifications to work with host-provided physical constants#30
Open
grantfirl wants to merge 1 commit into
Open
minor modifications to work with host-provided physical constants#30grantfirl wants to merge 1 commit into
grantfirl wants to merge 1 commit into
Conversation
grantfirl
requested review from
AndersJensen-NOAA and
dustinswales
as code owners
AndersJensen-NOAA
approved these changes
May 12, 2026
Collaborator
AndersJensen-NOAA
left a comment
AndersJensen-NOAA
left a comment
There was a problem hiding this comment.
I will merge this PR into branched version 3.0.6
Contributor
Author
OK, I've switched the target to tempo_3.0.6. Once that is done, are you planning on merging ufs-community/ccpp-physics#353 and changing it to point to the tempo_3.0.6 branch of TEMPO so that it will work? Also, what are your thoughts on the current failing UFS RTs? Should we just remove those and create a new regional test with a more suitable suite? If so, are you going to do this in the UWM PR, or is someone else? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@AndersJensen-NOAA This should be used in conjunction with AndersJensen-NOAA/ccpp-physics#6