DRAFT FOR DOM: Feature/capgen_for_fuji#718
Draft
dustinswales wants to merge 123 commits intoNCAR:developfrom
Draft
DRAFT FOR DOM: Feature/capgen_for_fuji#718dustinswales wants to merge 123 commits intoNCAR:developfrom
dustinswales wants to merge 123 commits intoNCAR:developfrom
Conversation
…en_unit_conversions
… into feature_capgen_unit_conversions
…al dimension name
… into feature_capgen_unit_conversions
…ature_capgen_unit_conversions
… into feature_capgen_unit_conversions
…be consistent with how the DEBUG checking is implemented in PR NCAR#512
…an modules in the correct place (#4) Update CMakeLists.txt to: - Bring in updates from NCAR ccpp-framework main as needed and update CMakeLists.txt to modern cmake version 3 - Support NEPTUNE cmake build while retaining compatibility with UFS/SCM
…an modules in the correct place (NCAR#653) **Update src/CMakeLists.txt: use modern cmake features to install Fortran modules in the correct place** Update CMakeLists.txt to modern cmake version 3 and support NEPTUNE cmake build while retaining compatibility with UFS/SCM User interface changes?: No Fixes: [Github issue #s] n/a Testing: all CI tests pass, ran `capgen` and `prebuild` tests locally on my laptop - all pass test removed: unit tests: system tests: manual testing: Associated PRs: - ccpp-physics: ufs-community/ccpp-physics#259 - FV3: NOAA-EMC/ufsatm#940 - ufs-weather-model: ufs-community/ufs-weather-model#2659
… feature/pull_in_dev_20250724
… feature/pull_in_dev_20250724
… feature/capgen_for_fuji
dustinswales
commented
Feb 3, 2026
| if skip_ddt_check: | ||
| register_fortran_ddt_name(pval_str) | ||
| # end if | ||
| pval = pval_str.lower() |
Member
Author
There was a problem hiding this comment.
Otherwise we get this error:
communicator: 'mpi_comm' is not a valid derived Fortran type
dustinswales
commented
Feb 3, 2026
| if iname is not None: | ||
| lname = lname + isep + iname | ||
| isep = ':' | ||
| # DJS2025: HACK. Check if dimension provided by host? |
Member
Author
There was a problem hiding this comment.
When we (@peverwhee and I) moved to passing the host_model dictionary to the Write Phases, this was not needed anymore. Also, during the Write Phases we then had access to the host_model DDT libraries to search for , and this wasn't an issue there.
I think(?) we need the host-model DDT library here, in the Group Analyze phase, and search for ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@climbfuji
Well here it is, worts and all.
I will add comments later on.