Fix logger recursion (NGWPC-8295)#3
Merged
cmaynard-ngwpc merged 2 commits intoSep 22, 2025
Conversation
27bba48 to
eb39604
Compare
zhengtaocui
reviewed
Sep 22, 2025
aabd427 to
eb39604
Compare
419e208 to
0788b3e
Compare
zhengtaocui
approved these changes
Sep 22, 2025
zhengtaocui
left a comment
There was a problem hiding this comment.
Instructions for using loggers have been added. I approve this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While testing Sac-SMA standalone, a run-time error occurred due to a recursive call to write_log. When write_log starts, it call initialize, which calls set_log_file_path which calls write_log. Refactored to use print statements since these really were not necessary in the log file, thereby removing recursion.
Additions
Removals
Changes
Checklist