Change Serialization Data Type to int#5
Open
idtodd wants to merge 3 commits into
Open
Conversation
sivasankkar
approved these changes
Jan 26, 2026
sivasankkar
left a comment
sivasankkar
left a comment
There was a problem hiding this comment.
All the changes to int32 are consistent and align with the BMI value type. This code can be merged. I recommend that we check with @PhilMiller when he is back on these to hear his thoughts as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whilst most BMIs will use
uint64for their serialization data types, the Fortran BMI models only have messaging interfaces for 32-bit integers. This PR aims to remove messaging that would imply the type is a 64-bit integer and casts to that data type. NGen will be updated to accommodate the limits of the Fortran BMI.