Reset time functionality added for state saving/restoring processes (NGWPC 9622)#6
Merged
Conversation
…nnecessary while testing the restore.
sivasankkar
changed the title
idtodd
reviewed
Feb 2, 2026
| call reset_model_time(this%model, exec_status) | ||
| if (exec_status == 0) then | ||
| bmi_status = BMI_SUCCESS | ||
| call write_log("Time variables reset successfully for state restoring", LOG_LEVEL_INFO) |
There was a problem hiding this comment.
Maybe the log level for this should be debug?
idtodd
approved these changes
Feb 2, 2026
cmaynard-ngwpc
approved these changes
Mar 12, 2026
cmaynard-ngwpc
left a comment
cmaynard-ngwpc
left a comment
There was a problem hiding this comment.
Successfully tested in AWS Workspace.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BMI save state implementation currently includes saving and loading the current time of the BMI. This is needed for properly loading state during checkpointing, but that would cause hindcasting loading of states to continually increase, and some BMIs might start looking for data in indexes out of range from the configuration files. An additional SetValue message of "reset_time" is needed to allow the NOAH OWP BMI to reset its current time to 0 as well as update any other values that create a BMI state equivalent to starting at 0.
Additional changes made to facilitate messaging between NGEN and the Fortran BMI.
Changes:
reset_timeinnoahowp_set_intfunction that calls another subroutine to reset time variables.reset_model_timethat resets time variables.serialization_sizeis a valid input for allowing theget_var_nbytesto reflect an incoming size for serialized data. This works around the limitation of passing arbitrarily sized serialization data to the Fortran BMI to read.