Skip to content

Conversation

@piperinazhang
Copy link
Collaborator

No description provided.

@gitguardian
Copy link

gitguardian bot commented Sep 23, 2025

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
10131098 Triggered Generic High Entropy Secret 933a412 approval-server/src/main/resources/application-dev.yml View secret
21111802 Triggered Generic Password a779fc1 approval-server/src/main/resources/application-dev.yml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@baiyaoshi baiyaoshi assigned baiyaoshi and unassigned baiyaoshi Sep 28, 2025
@baiyaoshi baiyaoshi self-requested a review September 28, 2025 11:23
@ResponseResult
public void updateNotice(@RequestBody NoticeOperateVO vo) {
User currentUser = UserInterceptor.userHolder.get();
if (currentUser.getRole() != 3) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里可以使用枚举类UserRoleEnum.ADMIN.getRole()

.time(noticeTime)
.createTime(LocalDateTime.now())
.updateTime(null)
.createUser(currentUser.getCreateUser())
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

创建者不应该是这个吧

private final CompetitionService competitionService;

@ResponseResult
@GetMapping("/admin/com/schema")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apifox上好像是/admin/com/getSchema

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

在这里获取表单你测试成功了吗,在Comepetition类添加@TableName(value = "competition", autoResultMap = true),后面resultData不需要toString


private final ScoreService scoreService;

@ResponseResult
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里不需要@ResponseResult,我好像测试没有成功,真的能用吗🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants