-
Notifications
You must be signed in to change notification settings - Fork 3
feat: set-whitelist #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 10131098 | Triggered | Generic High Entropy Secret | 933a412 | approval-server/src/main/resources/application-dev.yml | View secret |
| 21111802 | Triggered | Generic Password | a779fc1 | approval-server/src/main/resources/application-dev.yml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
| @ResponseResult | ||
| public void updateNotice(@RequestBody NoticeOperateVO vo) { | ||
| User currentUser = UserInterceptor.userHolder.get(); | ||
| if (currentUser.getRole() != 3) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里可以使用枚举类UserRoleEnum.ADMIN.getRole()
| .time(noticeTime) | ||
| .createTime(LocalDateTime.now()) | ||
| .updateTime(null) | ||
| .createUser(currentUser.getCreateUser()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
创建者不应该是这个吧
| private final CompetitionService competitionService; | ||
|
|
||
| @ResponseResult | ||
| @GetMapping("/admin/com/schema") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apifox上好像是/admin/com/getSchema
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
在这里获取表单你测试成功了吗,在Comepetition类添加@TableName(value = "competition", autoResultMap = true),后面resultData不需要toString
|
|
||
| private final ScoreService scoreService; | ||
|
|
||
| @ResponseResult |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里不需要@ResponseResult,我好像测试没有成功,真的能用吗🤔
No description provided.