Add an extra header/body separator CRLF to ensure the first line of the body does not become part of the header#23
Open
massar wants to merge 1 commit into
Open
Add an extra header/body separator CRLF to ensure the first line of the body does not become part of the header#23massar wants to merge 1 commit into
massar wants to merge 1 commit into
Conversation
…he body does not become part of the header Funny that in both instances (set/clear) there was a single word before the ':', thus really making it look like a header ;) Before for clearing the alarm: ``` List-Id: ring-sqa <sqa.ring.nlnog.net> X-Mailer: ring-sqa massar01.ring.nlnog.net: clearing ipv4 alarm <Other headers added by spam systems etc> <empty body> ``` Or for raising the alarm: ``` List-Id: ring-sqa <sqa.ring.nlnog.net> X-Mailer: ring-sqa Regarding: massar01.ring.nlnog.net ipv4 <anti-spam headers added by other systems> This is an automated alert from the distributed partial outage ... ``` After this change: ``` List-Id: ring-sqa <sqa.ring.nlnog.net> X-Mailer: ring-sqa <anti-spam headers> massar01.ring.nlnog.net: clearing ipv4 alarm ``` or for raising the alarm: ``` List-Id: ring-sqa <sqa.ring.nlnog.net> X-Mailer: ring-sqa <anti-spam headers added by other systems> Regarding: massar01.ring.nlnog.net ipv4 This is an automated alert from the distributed partial outage ... ```
Habbie
approved these changes
May 20, 2024
Member
|
The bug isn't exactly "we forgot to add an empty line", the bug is that I added the empty line incorrectly. I'm doing Now we keep the useless empty string at the end of the header array. |
Member
|
I've created another pull request, which attempts to solve the same, without leaving the useless empty string in front of the body. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A very simple fix that likely went unnoticed for a while ;) Thanks for building this system @ytti and @job very cool and useful!
Add an extra header/body separator CRLF to ensure the first line of the body does not become part of the header
Funny that in both instances (set/clear) there was a single word before the ':', thus really making it look like a header ;)
Before for clearing the alarm:
Or for raising the alarm:
After this change:
or for raising the alarm: