Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #682 +/- ##
==========================================
- Coverage 85.32% 85.31% -0.01%
==========================================
Files 68 68
Lines 4490 4495 +5
==========================================
+ Hits 3831 3835 +4
- Misses 659 660 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
singhd789
reviewed
Dec 1, 2025
| if kc in yml_dict.keys(): | ||
| del yml_dict[kc] | ||
|
|
||
| # Clean up any fre_properties in the platforms |
Collaborator
There was a problem hiding this comment.
Dropping a test like this into test_helpers.py might help out the code coverage report:
def test_yaml_clean():
input_yaml = {
"name": "test"
"platform": "ptest"
"target": "ttest"
"fre_properties": ["some", "list"]
"build": {"compile": "yaml1", "platform": "yaml2"}
"experiments": ["some", "list"]
"compile": {"info": "info1"}
"platforms": [{"name": "plat1"},
{"name": "plat2", "fre_properties": ["another", "list"]}]
}
# After cleaning - yaml should look like this
expected_yaml = {
"name": "test"
"platform": "ptest"
"target": "ttest"
"compile": {"info": "info1"}
"platforms": [{"name": "plat1"},
{"name": "plat2"}]
}
# Clean yaml
output_yaml = clean_yaml(input_yaml)
assert output_yaml == expected_yaml
singhd789
reviewed
Dec 9, 2025
| # Merge compile into combined file to create updated yaml_content/yaml | ||
| try: | ||
| yaml_content = self.combine_compile(yaml_content) | ||
| yaml_content = self.combine_platforms(yaml_content) |
Collaborator
There was a problem hiding this comment.
Though not necessary, it might be nice to have the functions in the class above follow how the yamls are combined here, which means 2 changes:
- Just switching the order of the functions around in
InitCompileYamlin this file - Switching around the order that class follows in
abstract_classes.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Updates code to allow for platform yaml to contain reusable variable that can be used in the compile yaml.
Issue ticket number and link (if applicable)
Fixes #681
Checklist before requesting a review