Skip to content

Conversation

@jd-lara
Copy link
Member

@jd-lara jd-lara commented Nov 21, 2025

This PR follows the same approach that DataFrames.jl had for backwards compatibility of PrettyTables and avoid a major release

hannahchubin and others added 3 commits November 21, 2025 12:44
* pushing this for now while I make a PR for TimeSeries.jl to update their PrettyTables compat, since TimeSeries is fixing PrettyTables to less than 3.0.0 right now

* updated PrettyTables and all tests passing
@jd-lara jd-lara marked this pull request as ready for review November 21, 2025 20:10
Project.toml Outdated
Mustache = "1"
Pkg = "1"
PrettyTables = "1.3 - 3"
PrettyTables = "2.1, 3.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jd-lara is this how I should implement the PrettyTables version for all the repos, or is this a special case for IS?

@jd-lara jd-lara requested a review from daniel-thom November 21, 2025 21:12
@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

❌ Patch coverage is 45.32872% with 158 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.42%. Comparing base (0ee9770) to head (243d6c1).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/utils/print_pt_v2.jl 0.00% 145 Missing ⚠️
src/utils/print_pt_v3.jl 90.57% 13 Missing ⚠️

❌ Your patch status has failed because the patch coverage (45.32%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #516      +/-   ##
==========================================
- Coverage   79.10%   78.42%   -0.69%     
==========================================
  Files          71       73       +2     
  Lines        6192     6247      +55     
==========================================
+ Hits         4898     4899       +1     
- Misses       1294     1348      +54     
Flag Coverage Δ
unittests 78.42% <45.32%> (-0.69%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/InfrastructureSystems.jl 44.44% <ø> (+4.44%) ⬆️
src/utils/print.jl 72.51% <100.00%> (-7.40%) ⬇️
src/utils/recorder_events.jl 92.10% <ø> (+0.84%) ⬆️
src/utils/print_pt_v3.jl 90.57% <90.57%> (ø)
src/utils/print_pt_v2.jl 0.00% <0.00%> (ø)

... and 27 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jd-lara jd-lara merged commit bef6973 into main Nov 21, 2025
7 of 10 checks passed
@jd-lara jd-lara deleted the jd/some_claude_changes branch November 22, 2025 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants