[BREAKING] Remove HydroEnergyReservoir struct

[rodrigomha]

@jarry7 @jd-lara @m-bossart @kdayday

This is one of the major changes that we need to do to complete the Hydro updates. This will break many things and we need to debug what is breaking everywhere.

As of right now, the generator mapping will require update for the RTS to handle the EnergyReservoir that is there.

[jarry7]

@rodrigomha - ok, it seems to be what it is.

For clarity:

1. We will not be supporting HydroEnergyReservoir anymore (and related PSI formulations).
2. We are replacing this with HydroTurbine (which then needs a HydroReservoir attached to it).

If so, which formulations are we confident will work at runtime right now and which in the near future (with PSI and HPS)?

We likely do not have extensive amounts of time to debug and address issues in our large-scale models considering project-specific timelines (this is why I ask).

[kdayday]

I assume documentation is failing and hasn't been tested by compiling? The only other reference I see is in the migration guide from version 3.0 to 4.0, where hyperlinks need to be removed. Also maybe add a note that the struct was removed in v5

[jd-lara]

@rodrigomha - ok, it seems to be what it is.

For clarity:

1. We will not be supporting HydroEnergyReservoir anymore (and related PSI formulations).
2. We are replacing this with HydroTurbine (which then needs a HydroReservoir attached to it).

If so, which formulations are we confident will work at runtime right now and which in the near future (with PSI and HPS)?

We likely do not have extensive amounts of time to debug and address issues in our large-scale models considering project-specific timelines (this is why I ask).

@jarry7 the formulations are the same in HPS and they have tests. See https://github.com/NREL-Sienna/HydroPowerSimulations.jl/blob/9588e5d4867a41cf6fea9306ac6f36b1e65805d9/test/test_device_hydro_constructors.jl