Support variable-width shader model parsing for SM 6.10+#23
Merged
Conversation
…on: single underscore, decimal major/minor (1–4 digits each).
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parse shader model versions with variable-width components
Replace fixed 3-character / [0][2] digit shader model checks with
ParseShaderModelVersion, which accepts a single underscore separator and
decimal major/minor components of 1–4 digits each.
Use the parser in Options::Parse and ConfigLine::Parse so CLI and config-file
validation behave consistently. This is required for SM 6.10 and above, where
the old fixed-width parsing is insufficient.
Enable -enable-16bit-types on the DXC path for SM 6.2 and newer, update the
-m/--shaderModel help text, and keep the helper under the OPTIONS section.