-
Notifications
You must be signed in to change notification settings - Fork 719
[PyTorch][CP] Add THD format support for AllGather-based Context Parallelism #2829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sudhakarsingh27
wants to merge
46
commits into
NVIDIA:main
Choose a base branch
from
sudhakarsingh27:cp_thd_swa_with_ag
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
46 commits
Select commit
Hold shift + click to select a range
db44fc2
[PyTorch][CP] Fix THD AllGather CP: offset-based approach with proper…
sudhakarsingh27 1a5ca4c
[PyTorch][CP] Enable THD+all_gather tests in test_attention_with_cp
sudhakarsingh27 b4db9eb
[PyTorch][Fused Attn] Fix max_logit masking for non-zero-starting cu_…
sudhakarsingh27 7491ab6
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] b957725
some cleanup of ag+thd impl and gate e e te test for flash+ag+thd
sudhakarsingh27 c89173c
Merge branch 'cp_thd_swa_with_ag' of github.com:sudhakarsingh27/Trans…
sudhakarsingh27 18e41bd
Merge branch 'main' of github.com:NVIDIA/TransformerEngine into cp_th…
sudhakarsingh27 0b48746
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 608106d
improve the logic and remvoe for loop from the code
sudhakarsingh27 4b95130
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 15af3af
Merge branch 'main' of github.com:NVIDIA/TransformerEngine into cp_th…
sudhakarsingh27 5bec5b3
Merge branch 'cp_thd_swa_with_ag' of github.com:sudhakarsingh27/Trans…
sudhakarsingh27 89b1066
AG+THD SWA: extend KV visibility for right window and rename a2a-spec…
sudhakarsingh27 55fc2cd
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] f499f59
Merge branch 'main' of github.com:NVIDIA/TransformerEngine into cp_th…
sudhakarsingh27 2569a65
Merge branch 'cp_thd_swa_with_ag' of github.com:sudhakarsingh27/Trans…
sudhakarsingh27 4e4212f
resolved merge conflicts with main
sudhakarsingh27 10e4cfc
[PyTorch] Add pad_between_seqs support for FlashAttention 3 with CP
sudhakarsingh27 2a49dee
[PyTorch] Add pad_between_seqs tests for CP and non-CP FlashAttention
sudhakarsingh27 34e3d62
[QA] Add CP deterministic tests to L3 and support TE_PATH in FA test
sudhakarsingh27 4745f98
[PyTorch] Fix FA3 deterministic gate to match upstream backward const…
sudhakarsingh27 4be004f
[PyTorch] Disable FlashAttention 4 for pad_between_seqs with THD
sudhakarsingh27 c476f15
Merge branch 'main' of github.com:NVIDIA/TransformerEngine into flash…
sudhakarsingh27 a2b0f1b
[QA] Fix cutlass-dsl utils shadow in FA versions test
sudhakarsingh27 0ee22c7
merge conflicts with main
sudhakarsingh27 dfc1472
Merge branch 'main' of https://github.com/NVIDIA/TransformerEngine in…
sudhakarsingh27 ac38d4f
merge flash attn pad bw seqs
sudhakarsingh27 b94e175
Merge branch 'main' of github.com:NVIDIA/TransformerEngine into flash…
sudhakarsingh27 7ebe3d9
fixes after merging with flash_attn_pad_bw_seqs branchj
sudhakarsingh27 ddaa196
Merge branch 'main' of https://github.com/NVIDIA/TransformerEngine in…
sudhakarsingh27 fc9182f
skip tests which OOM in deterministic+backward+hopper+large_configs a…
sudhakarsingh27 636666f
Merge branch 'main' of github.com:NVIDIA/TransformerEngine into flash…
sudhakarsingh27 7928bc9
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 1585ebb
Merge branch 'flash_attn_pad_bw_seqs' of github.com:sudhakarsingh27/T…
sudhakarsingh27 7ecad01
[PyTorch][CP] Replace Python-loop THD reorder with kernel-backed perm…
sudhakarsingh27 d8bf5c5
Merge remote-tracking branch 'sudhakar_repo/flash_attn_pad_bw_seqs' i…
sudhakarsingh27 cc104d3
[PyTorch][CP] Fix AllGather SBHD forward: set cu_seqlens_kv_per_step
sudhakarsingh27 2464f43
make cp det and nondet tests run in parallel whenever possible
sudhakarsingh27 26e9f6f
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 611d876
[PyTorch][CP] Fix THD AllGather forward stream race on k_ag/v_ag
sudhakarsingh27 0aae820
Merge branch 'cp_thd_swa_with_ag' of github.com:sudhakarsingh27/Trans…
sudhakarsingh27 789ccf0
Merge branch 'main' into flash_attn_pad_bw_seqs
sudhakarsingh27 0a32185
Merge branch 'main' of github.com:NVIDIA/TransformerEngine into flash…
sudhakarsingh27 c33cf2d
Merge branch 'flash_attn_pad_bw_seqs' of github.com:sudhakarsingh27/T…
sudhakarsingh27 353361a
Merge remote-tracking branch 'sudhakar_repo/flash_attn_pad_bw_seqs' i…
sudhakarsingh27 a1062d9
Merge branch 'main' of github.com:NVIDIA/TransformerEngine into cp_th…
sudhakarsingh27 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A general comment - please run the CP file with "test_essential=False" offline because the essential tests may not cover everything.