cmake: Fix conflicting optimization flags in debug builds#15
Open
a-szegel wants to merge 1 commit intoNVIDIA:develfrom
Open
cmake: Fix conflicting optimization flags in debug builds#15a-szegel wants to merge 1 commit intoNVIDIA:develfrom
a-szegel wants to merge 1 commit intoNVIDIA:develfrom
Conversation
- Change CONFIG:Debug to CONFIG:debug for case sensitivity - Remove trailing semicolons in flag lists - Replace $<IF:...> with mutually exclusive $<$<condition>:...> for CUDA flags to avoid false branch evaluation on C++ files Fixes debug builds incorrectly getting both -O0 and -O3 flags. Signed-off-by: Seth Zegelstein <szegel@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$<IF:...>with mutually exclusive$<$<condition>:...>for CUDA flags to avoid false branch evaluation on C++ filesFixes debug builds incorrectly getting both -O0 and -O3 flags.
On Devel:
With this PR (no
-O0 -g -O3in debug build):