Switch from string-similarity to string-similarity-js as deprecated

[PadowYT2]

and remove lock file in favor of yarn

[tadhgboyle]

Not sure that pulling an abandoned libraries code into our codebase is a great solution here - it puts the responsibility of maintaining this (complex) code on us. The package is still working fine even though it's not maintained anymore (because it does 1 thing and it does that thing well, there is no need for it to get updated) - I don't personally see any point in doing this

[PadowYT2]

Not sure that pulling an abandoned libraries code into our codebase is a great solution here - it puts the responsibility of maintaining this (complex) code on us. The package is still working fine even though it's not maintained anymore (because it does 1 thing and it does that thing well, there is no need for it to get updated) - I don't personally see any point in doing this

Well as the package is depcreated, why use it and not just integrate it within the code? You don't need to mantain the code as the code hasn't be touched for years and works fine. Also Super himself wanted to do it "later"

[samerton]

I agree with aber here - I don't think copying the code into our codebase is the best thing to do. I see the following options:

1. We create our own implementation from scratch
2. We fork the deprecated package and maintain it ourselves in a new repository
3. We find an alternative library
4. We continue to use the deprecated library

[PadowYT2]

I agree with aber here - I don't think copying the code into our codebase is the best thing to do. I see the following options:

1. We create our own implementation from scratch
2. We fork the deprecated package and maintain it ourselves in a new repository
3. We find an alternative library
4. We continue to use the deprecated library

There's an alternative - https://www.npmjs.com/package/string-similarity-js, seems good and even less code

[supercrafter100]

lgtm

[supercrafter100]

Awaiting Aber's review on this one as well

[PadowYT2]

👀