Fix evaluating ATA Error Count: 0 as a warning#111
Merged
Napsty merged 1 commit intoNapsty:masterfrom Oct 3, 2025
Merged
Conversation
Owner
|
Thanks for the PR! Makes sense to me. |
Contributor
Author
|
The output before excluding 0: The output after excluding 0 via this patch: |
Owner
|
LGTM, thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without the definition of an ata_errors warning level the smart output of
ATA Error Count: 0ends up inata_errors is non-zero (0)[/dev/sda]in the output.So the zero case needs to be excluded explicitly checking ATA error counts.