Skip to content

Comments

Multi yoy integration - combines PRs #456, #460 and #464 at once.#470

Open
cdeline wants to merge 93 commits intodevelopmentfrom
multi_YoY_integration
Open

Multi yoy integration - combines PRs #456, #460 and #464 at once.#470
cdeline wants to merge 93 commits intodevelopmentfrom
multi_YoY_integration

Conversation

@cdeline
Copy link
Collaborator

@cdeline cdeline commented Dec 10, 2025

See individual PR's #456, #460 and #464 for discussion.

Issues & PRs

  • Code changes are covered by tests
  • Code changes have been evaluated for compatibility/integration with TrendAnalysis
  • New functions added to __init__.py
  • API.rst is up to date, along with other sphinx docs pages
  • Example notebooks are rerun and differences in results scrutinized
  • Updated changelog

cdeline and others added 30 commits May 28, 2025 14:31
if label not in {None, "right", "left", "center"}:
raise ValueError(f"Unsupported value {label} for `label`."
" Must be 'right', 'left' or 'center'.")
if label is None:
Copy link
Collaborator

@martin-springer martin-springer Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

users would need to pass label=None explicitly to trigger those checks but end up with label='right'. I think it's best to rely on the default handling.

I'll remove the label is None handling in degradation.py and plotting.py. I'll also update the tests that specifically trigger this. Commit 0fe8ebd

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 11 changed files in this pull request and generated 5 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

return Rd_pct


def _avg_timestamp_old_Pandas(dt, dt_left):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With pandas three now released, should we think about dropping support for pandas 1.x.x?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, maybe we start with a deprecation warning for pandas < 2.0 in our next release. Pandas 2.0 was only put out in 2023 so we can probably hang on to this functionality for a few more years - its not really causing any harm. PVLib is still on pandas > 1.3.3 so we should probably still support it too...

@cdeline
Copy link
Collaborator Author

cdeline commented Feb 17, 2026

@martin-springer - check out the example notebook with label='center' and multi_yoy=True functionality.

@martin-springer
Copy link
Collaborator

martin-springer commented Feb 19, 2026

@martin-springer - check out the example notebook with label='center' and multi_yoy=True functionality.

@cdeline - It's looking great. The multi-yoy analysis really narrows down the distribution!

Regarding the labelling:

  1. Should we add an index name to the tables:
?? some name here ?? dt_right dt_center dt_left
2010-08-27 12:00:00-07:00 2011-02-26 00:00:00-07:00 2010-08-27 12:00:00-07:00 2010-02-26 00:00:00-07:00
  1. Should we try to come up with a plot that illustrates the difference?

@cdeline
Copy link
Collaborator Author

cdeline commented Feb 19, 2026

Regarding the labelling:

  1. Should we add an index name to the tables:

?? some name here ?? dt_right dt_center dt_left
2010-08-27 12:00:00-07:00 2011-02-26 00:00:00-07:00 2010-08-27 12:00:00-07:00 2010-02-26 00:00:00-07:00

previous label was 'dt'. We could go back to that, or have a more descriptive label of either dt_right, dt_center or dt_left. I'm not sure how much of a problem it would be to have a returned dataframe with index name that changes depending on what labeling is selected. Keeping 'dt' index label would be consistent with previous version.

  1. Should we try to come up with a plot that illustrates the difference?

These are two illustrations that I've used in the past to describe center vs right labeling. I could just upload the images to the notebook as an example:

image image

@martin-springer
Copy link
Collaborator

@cdeline - great, thank you for making those changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants