Mark some unused variables#5334
Open
out-of-phaze wants to merge 1 commit into
Open
Conversation
| abstract_type = /decl/background_detail/citizenship | ||
| category = /decl/background_category/citizenship | ||
| var/ruling_body = "Other Faction" | ||
| var/ruling_body = "Other Faction" // currently unused? todo: display this or remove it? nothing seems to actually set it... |
Contributor
There was a problem hiding this comment.
I think this might have been a partial port from the Polaris sync, it should be in the info box on chargen. I can do this if I remember.
Member
Author
There was a problem hiding this comment.
noted, think that's the only one still standing then? EDIT: that and tallness
MistakeNot4892
requested changes
Apr 9, 2026
Contributor
MistakeNot4892
left a comment
MistakeNot4892
left a comment
There was a problem hiding this comment.
Per comments some of these can just be removed.
MistakeNot4892
added
awaiting author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Marks some unused variables I don't feel comfortable implementing myself, mostly because they're other people's code.
Why and what will this PR improve
Leaves a visible note that these variables are unused and need to be implemented or removed.